Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute invalid column proof error to correct peer #6377

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Sep 9, 2024

Issue Addressed

Before PeerDAS we send to the beacon processor a "block component" which is a set of things to verify, crucially all coming from the same peer. If the processor says "invalid" we just penalize the unique provider peer.

This (block component) -> (1 peer) link breaks for PeerDAS. Now the set of custody columns may come from a set of more than 1 peer. We need a way for the beacon processor to attribute fault to the right peer.

Proposed Changes

  • When verifying a batch of columns, if there's a failure re-verify individually to attribute fault. This adds CPU time but a failure will cause the offending peer to be quickly banned so it's not a DoS vector.
  • Extend Kzg verification errors to include the index of the invalid column
  • Update lookup sync handling of processing results to locate the provider of the invalid column and penalize it

Caveats

The re-verification of each individual column could be done more efficiently. However, we rarely get invalid columns so it's not critical to optimize this path. Offending peers will be quickly banned.

To upload the statement above I think we should increase the penalty to invalid processing results from mid-tolerance to high tolerance.

@dapplion dapplion added ready-for-review The code is ready for review das Data Availability Sampling labels Sep 9, 2024
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@realbigsean
Copy link
Member

@mergify queue

Copy link

mergify bot commented Sep 23, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d84df57

mergify bot added a commit that referenced this pull request Sep 23, 2024
@mergify mergify bot merged commit d84df57 into unstable Sep 23, 2024
28 checks passed
@mergify mergify bot deleted the peerdas-peergroup-scoring-only branch September 23, 2024 18:49
@realbigsean realbigsean restored the peerdas-peergroup-scoring-only branch September 23, 2024 23:06
@realbigsean realbigsean deleted the peerdas-peergroup-scoring-only branch September 23, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants