Attribute invalid column proof error to correct peer #6377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Before PeerDAS we send to the beacon processor a "block component" which is a set of things to verify, crucially all coming from the same peer. If the processor says "invalid" we just penalize the unique provider peer.
This (block component) -> (1 peer) link breaks for PeerDAS. Now the set of custody columns may come from a set of more than 1 peer. We need a way for the beacon processor to attribute fault to the right peer.
Proposed Changes
Caveats
The re-verification of each individual column could be done more efficiently. However, we rarely get invalid columns so it's not critical to optimize this path. Offending peers will be quickly banned.
To upload the statement above I think we should increase the penalty to invalid processing results from mid-tolerance to high tolerance.